Final Fantasy Hacktics

1.  So I was poking around in World.Bin to see if I can allow the player to rename Holy Dragons.  I used this hack:

I'm not 100% sure how this hack works, but setting r2 = 0 on the line before the branch will function like this hack, and r2 = 1 will disable all renaming.  However I can't find where the hardcoding is that prevents Holy Dragon (job 48) from being renamed. :(  Possibly relevant:  http://ffhacktics.com/wiki/001210e8_-_001212b4

2.  I've had a couple failed attempts at coding Pain Split (like the Pokemon move).  Check in the beginning is the same immortal flag check that I used in several of my other formula hacks (will cause the move to fail if the unit is immortal), you can remove these lines if you want.  I'm not quite sure what I'm doing wrong here. :'(  This one does what I want it to, to the target; but not to the caster:



3.  I'm also making an ability that adds +1 PA/MA to the guy with the ability if he kills something.  I've tried it in at least 7 different routines, no idea if the code is erroneous at this point or if I need to just keep trying routines until I get the right one.  How do I find the right routine for this one?  Possibly erroneous code:



4.  Another method of poking around reveals I might have some hard coding around 0x001a0c80 battle.bin that affects the reaction slots that are screwed up/currently disabled that I mentioned in another topic.  However there's no documentation in the wiki between 0019f2f4 - 001a0f6c.  Does anyone happen to have it?

5.  So I managed to figure out this: http://ffhacktics.com/wiki/00125540_-_001255e0  However I'm not quite sure what the addiu r2,r0,0xfffd or addiu r2,r0,0xfffa  lines do outside of what I'd written in the wiki.  By that I mean, is there a way to customize the options of what is locked outside of those options?  Such as if I wanted something to be able to equip items and not equip additional abilities.

For the pain split hack, is there any reason why you used a arithmetic shift instead of a logical one? Are any of the values you used signed? Just something I noticed. Not sure if that's the root of the problem, but I can't really see any other problem with it.

I don't know the difference between the shifts.  Copied it from a similar segment of code elsewhere that divides something by 2.

Use a logical shift, srl or sll respectfully. But not the issue. I'm about 90% sure that the issue is that you did not set the hit flag (byte x25) for HP damage (activating bit x80) on either the target or user. Look at the self destruct formula if you want an example of the flags being loaded and altered.

For #2: This could get weird if the damage and/or recovery numbers are negative.  It might work but the display would probably be bizarre.  You might want to check if damage is negative and if so, add it to recovery, and vice versa.
If the problem is the display type (0x25) then the effects of the ability would still happen, it just wouldn't show you the damage and recovery numbers.  Check your units' HP values to see if they were modified...

#3: I would think that code would just be inserted into the formula you're changing.  Where else?

#5: I would look at the routine that calls that one to see what checks it makes on r2 immediately following the call.

for #1, if you know the party ID or party data or Job ID anywhere in the routine, you could jump to a custom routine that checks the Job ID vs. what you want to rename, set the conditions for success (r2 = 0), and jump back to the branch.

Update:

1.  On the Pain Split formula - The hit flag for HP damage appears to be tied to the display, and doesn't seem to be affecting anything else.  I tested a version that sets the hit flag, and it has the same (broken) effect it did before only this time it displays damage.  This is also the reason that the Endeavor formula only displays 100% (if target can be hit by it) or 0% (if immune).  Looking into it and getting a flag for HP damage attached to it produces a glitchy looking 999 value for display if the ability heals damage and displays as normal if it deals damage. 

2.  So I think I got somewhere with this ability, but it's still not working.  I tested it to just add +1 PA to the unit who is attacking if it kills a target.  Managed to find a routine that I know for sure it's reading this code but I have no idea how to get it to function.