The Lion War 2.031 - Bug Reports

[3lric]

I play that at ch 1 and after play be a beta at ch 2, when i win it just freeze like that.
Also skill for Monk and Thief have bug. I already have all monk and thief skill, but not master it

The second part is not a bug. You havent gotten far enough. Please do a bit of reading into what you are playing.

[toolarg]

Hello, I ran into a minor visual bug. After the battle with Zalera I decided to add Meliadoul to the party, party was full so I was prompted to select a unit to dismiss, I started scrolling through my units and when I reached my generic Dark Knight his portrait was that of Velius. When I was done and returned to the world map and the formation screen his portrait was the correct one. Thank you for all your work, love the mod.

[SuccuBelle]

Edit: So I saw someone else had a similar problem when using these two mods together, so I re-patched a copy with just TLW on it, and I got a similar but different error. This time, the background was present during the text crawl (it was not before), and when it froze, instead of playing the music endlessly, it just played one note endlessly.

Hello, I am playing TLW on Duckstation with the QOL Patch. I am at the battle with Cu Chulainn, and the battle plays out as normal, but after the cutscene with Delita and the text crawl, when the game goes to a black screen, it never loads the next screen, and the music continues to play ad infinitum. I'm pretty sure it's some sort of emulation issue, but I don't know what to try. It has crashed 4 times.

[RetroTypes]

Edit: So I saw someone else had a similar problem when using these two mods together, so I re-patched a copy with just TLW on it, and I got a similar but different error. This time, the background was present during the text crawl (it was not before), and when it froze, instead of playing the music endlessly, it just played one note endlessly.

Hello, I am playing TLW on Duckstation with the QOL Patch. I am at the battle with Cu Chulainn, and the battle plays out as normal, but after the cutscene with Delita and the text crawl, when the game goes to a black screen, it never loads the next screen, and the music continues to play ad infinitum. I'm pretty sure it's some sort of emulation issue, but I don't know what to try. It has crashed 4 times.

If you're applying the whole QoL pack, you need to reapply the EIUH from the TLW resources after patching the QoL, as it says in the QoL thread. So base ISO -> TLW -> QoL -> EIUH hack. If you're still getting errors after that, let us know.

[Jaylo]

Is there a problem with Balthier's Barrage ability when used with Secret Hunt?
I am getting two poached messages when a poach occurs with strikes 1-3 and the game seems to "stop" if a poach occurs on strike 4.
I say "stop" and not "freeze" because the music still plays and the unit animations are still working but there is no ui and the game doesn't continue.

[Nyzer]

Is there a problem with Balthier's Barrage ability when used with Secret Hunt?
I am getting two poached messages when a poach occurs with strikes 1-3 and the game seems to "stop" if a poach occurs on strike 4.
I say "stop" and not "freeze" because the music still plays and the unit animations are still working but there is no ui and the game doesn't continue.

Great discovery, thank you.

So, after some investigation, it turns out that behind the scenes, the Poach/Train checks run before the Barrage formula reduces the damage of the ability, due to the way the formula is set up. This means it can think it's reaching the target damage range only to turn out that the damage was reduced OUT of that range, but it's already been set to trigger Poach/Train.

There are probably ways to fix that up for the formula specifically, but the code for the poach/train routine was very unoptimized and it was a lot faster to just add in a check to block the Barrage ability ID before even taking the time to figure out what the problem actually was.

If you have the OrgASM program from the TLW resources (or just the FFTPatcher Suite), you can add this to your FFTPatcher > XmlPatches > PSX folder and apply it to the game.

[Jaylo]

Great discovery, thank you.

So, after some investigation, it turns out that behind the scenes, the Poach/Train checks run before the Barrage formula reduces the damage of the ability, due to the way the formula is set up. This means it can think it's reaching the target damage range only to turn out that the damage was reduced OUT of that range, but it's already been set to trigger Poach/Train.

There are probably ways to fix that up for the formula specifically, but the code for the poach/train routine was very unoptimized and it was a lot faster to just add in a check to block the Barrage ability ID before even taking the time to figure out what the problem actually was.

If you have the OrgASM program from the TLW resources (or just the FFTPatcher Suite), you can add this to your FFTPatcher > XmlPatches > PSX folder and apply it to the game.

Thanks for the quick reply.
So the first poach message is an illegal poach done with full damage which needs another strike to give you the legal poach message.
If the illegal poach happens on the 4th strike there is no 5th to correct it so the game just stops.
This is a shame as the Barrage skill is the best for poaching with it's four strikes.

[Nyzer]

Thanks for the quick reply.
So the first poach message is an illegal poach done with full damage which needs another strike to give you the legal poach message.
If the illegal poach happens on the 4th strike there is no 5th to correct it so the game just stops.
This is a shame as the Barrage skill is the best for poaching with it's four strikes.

Okay, this should do it.

So the way the Barrage formula works normally is by calling the routine for switching from a Break attack to a normal weapon attack and then calculating the damage reduction from there. Unfortunately, the routine for switching to a normal weapon attack runs the Poach/Train routine before returning to the Barrage formula.

I just added some more lines to the Barrage code before it runs the switch to weapon attack routine, flipping a switch in some empty data, then made the Poach/Train routine check if that switch was flipped. If so, it skips running the Poach/Train checks. After running the switch to weapon attack routine and returning to Barrage to calculate the true final damage result, I flip that switch off, then jump directly to the Poach/Train routine using the new (and correct) damage numbers.

I was hoping it would be that simple in the end, but I didn't have time to test last night. I'm glad I was right, though!

For bonus points, this is even the version of Barrage I've already upgraded so that it will show the spell effect when using a Magic Gun.

Make sure to double-check the Conflict Checker in TLW/otL's OrgASM against the existing hacks that there are no conflicts, though. As the code was expanded, if there was something else immediately after it, it will now bleed into other hacks' code and cause issues.