Modding => Help! => Topic started by: Rfh on January 14, 2012, 10:24:52 am
Title: Formula 2D gain elemental
Post by: Rfh on January 14, 2012, 10:24:52 am
An ASM that make formula 2D Dmg_(PA*(WP+Y)) 100% Status gain elemental? Excuse me, I'm a bit tedious.
Title: Re: Formula 2D gain elemental
Post by: formerdeathcorps on January 14, 2012, 12:14:22 pm
That's what Zodiac's Weapon Strike Fix does. If you flag the blank flag under Hit Alllies, it'll take the only the element of the ability. Or alternatively, on my version of that hack, if you unflag Weapon Strike, it'll only take the element of the ability.
Title: Re: Formula 2D gain elemental
Post by: Rfh on January 14, 2012, 01:46:12 pm
Quote from: formerdeathcorps on January 14, 2012, 12:14:22 pm That's what Zodiac's Weapon Strike Fix does. If you flag the blank flag under Hit Alllies, it'll take the only the element of the ability. Or alternatively, on my version of that hack, if you unflag Weapon Strike, it'll only take the element of the ability.
Thanks, but... the elemental damage of these abilities with formula 2D aren't strengthen by an item attribute, and the hack override concentration bonus. Is possible that can strengthen the elemental damage? For example, Excalibur (strengthen holy) should strengthen Stasis Sword (holy elemental)
Title: Re: Formula 2D gain elemental
Post by: Glain on January 14, 2012, 02:00:37 pm
I just coincidentally did a hack that I've been testing that was essentially a rewrite of [2d], [2f], and [30], mainly to give the Dark/Night Sword abilities the same properties as Holy Sword (allow elemental, strengthen, status proc, etc), but one of the changes was also to allow elemental strengthening even if it's on the ability and not the weapon. It should work with the flag under Hit Allies that fdc mentioned.
If you have a patch changing these formulas already, it could overwrite something.
(Edited patch out due to newer version below)
Title: Re: Formula 2D gain elemental
Post by: formerdeathcorps on January 14, 2012, 02:39:36 pm
Ideally, Glain, you want to strengthen both weapon and ability element.
This is the ASM for formula 2D. However, what Rfh says still doesn't make sense. Zodiac's routine fixes only the elemental routine. This routine is after the evasion routine. There is no reason why the support skill Concentrate would fail unless the flag under Hit Allies is what's responsible (which I see no reference to in any of the evasion routines). Are you sure it's not from one of your other patches?
Title: Re: Formula 2D gain elemental
Post by: Glain on January 14, 2012, 04:11:22 pm
Yes, it should be strengthening both with the patch.
In the old hack, the strengthen routine is called (on the current elements, which consists of just the weapon element), then the new element (based on the ability itself) is figured out; I switched the order, so that the new elements are figured out first, then it calls the strengthen routine using those elements.
And yes, I have no idea how that could possibly affect Concentrate. I didn't even notice that the first time I read the post.
Title: Re: Formula 2D gain elemental
Post by: RavenOfRazgriz on January 14, 2012, 05:30:56 pm
In the old hack, the strengthen routine is called (on the current elements, which consists of just the weapon element), then the new element (based on the ability itself) is figured out; I switched the order, so that the new elements are figured out first, then it calls the strengthen routine using those elements.
And yes, I have no idea how that could possibly affect Concentrate. I didn't even notice that the first time I read the post.
Tl;dr it all works as intended? I have no clue what the flag under Hits Allies discussion is about, I never knew about that before, but I assume that means flagging it causes it to ignore Weapon Element even if Weapon Strike is flagged?
This is actually 90% of a hack I asked FDC to do for me... want to save him work and do the other 10%? Haha.
Title: Re: Formula 2D gain elemental
Post by: formerdeathcorps on January 14, 2012, 05:53:10 pm
Quote from: RavenOfRazgriz on January 14, 2012, 05:30:56 pm I have no clue what the flag under Hits Allies discussion is about, I never knew about that before, but I assume that means flagging it causes it to ignore Weapon Element even if Weapon Strike is flagged?
You assume right, but part of this confusion can be attributed to Zodiac when he wrote the hack. He assumed that his hack would affect the elemental of every formula. However, the routine he jumped from only affected HOLY SWORD. Recall that the popular demand was to take the element of the ability. After the hack was released, it satisfied this demand because weapon element + ability element for most patches at the time (vanilla remakes) would be ability element (since most weapons don't have elements). Since it also didn't affect any other formulas, no one bothered to bug-check this or fully read Zodiac's description which said that if you flagged the "unused flag" under Hit Allies, you will take only ability element.
Alas, things don't work entirely as expected. When I was going over flag consolidation for the formula hack, I found that the "unused flag" is actually used in determining where a unit can target. Thus, it would probably be best to move it away from there and simply do weapon strike = ability + weapon elemental and no weapon strike = ability elemental. From there, you can easily cover all three cases: 1) Ability element = Unflag Weapon Strike 2) Ability + Weapon element = Flag Weapon Strike 3) Weapon element = Flag Weapon Strike on a non-elemental ability
The only significant loss is to the weapon swinging animation in Case 1), but let's make sure that "unused flag" doesn't actually affect anything.
Title: Re: Formula 2D gain elemental
Post by: RavenOfRazgriz on January 14, 2012, 06:03:54 pm
Losing the weapon swing is a significant loss though. It makes your patch look like shit if you need that function. I can actually see use for the first situation where a Weapon Strike is required. Are there any other empty flags that the Ability Element override thing could be moved to?
I know once you finish the Formula Hack, none of this should be an issue, but for now, having all three functions working properly would be nice since the code for an "override" flag already exists, and we just need to find a flag that isn't being used for it to work correctly.
Title: Re: Formula 2D gain elemental
Post by: Rfh on January 15, 2012, 08:09:47 am
Mmm, I've tested in clean ISO with your patch and elements doesn't strengthen. Am I doing something wrong?
Title: Re: Formula 2D gain elemental
Post by: Glain on January 15, 2012, 10:56:18 am
Hmm... it seems I had the order of a few things wrong. Try this one:
<Patch name="Swordskill element strengthen and Dark/Night Sword elemental"> <Description> Swordskill element fix - like previous fixes, but with Dark/Night sword elemental, using (WP+Y) and can status proc like Holy Sword can; Also, elements should strengthen even if they're not on the weapon. </Description> <Location file="BATTLE_BIN" offset="F5C00"> E8FFBD27 1000BFAF 0C00B0AF 21808000 4421060C 00000000 2E004014 00000000 9717060C 00000000 1980083C F7380481 04390581 F4380681 2000C630 0200C01C 00000000 25208500 043904A1 E917060C 00000000 A921060C 00000000 1980043C 0439848C 00000000 A613060C 00000000 1980023C 902D428C 00000000 00004290 00000000 03004010 00000000 3F1C060C 00000000 0D000012 00000000 02000824 08000812 00000000 921C060C 00000000 81000834 07004814 00000000 33730508 00000000 1B1D060C 00000000 AD1F060C 00000000 1000BF8F 0C00B08F 1800BD27 0800E003 00000000 </Location> <Location file="BATTLE_BIN" offset="12026C"> 00000000 </Location> <Location file="BATTLE_BIN" offset="1202E0"> 00000000 </Location> <Location file="BATTLE_BIN" offset="12048C"> 00000000 </Location> <Location file="BATTLE_BIN" offset="122B20"> 00730508 00000424 </Location> <Location file="BATTLE_BIN" offset="122C90"> 00730508 01000424 </Location> <Location file="BATTLE_BIN" offset="122C50"> 00730508 02000424 </Location> <Location file="BATTLE_BIN" offset="120338"> 81000234 </Location> </Patch>
Title: Re: Formula 2D gain elemental
Post by: Rfh on January 15, 2012, 02:33:37 pm