Main Site

Forum Index

Please login or register.

Login with username, password and session length
Advanced search  

News:

Welcome to FFH, where all your dreams come true!

Pages: 1 2 3 [4]
Mediator
Eternal [Posts: 2416] Logged
  • View Profile
  • share
  • [March 04, 2012, 08:22:31 PM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #60 on: March 04, 2012, 08:22:31 PM »
Yay, I can finally bring Drain back!

Here dying, join my legion of undeath. Your blood, the roses on unhallow'd graves!
Glain [Posts: 356] Logged
  • View Profile
  • share
  • [March 12, 2012, 11:39:13 PM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #61 on: March 12, 2012, 11:39:13 PM »
So it turns out the patch was only giving the correct element to the action for the first target it hit. Then it was zeroing out the ability element (too early). I've got a new patch to correct that! I'm not sure this one overwrites everything the other one did, so best use on an ISO that doesn't have the old patch applied.
Austin [Posts: 307] Logged
  • View Profile
  • share
  • [April 24, 2012, 02:28:25 AM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #62 on: April 24, 2012, 02:28:25 AM »
Alright, I'm back again from my most recent hiatus and trying this out again. It's still giving me the same problems as before, if you make the knight stat break skills elemental and hit something that cancels that element and has a reaction ability that targets itself it will always miss.

So I'm testing this by making squires cancel dark then hitting them with dark element break skills. The skill will miss like it's supposed to, but if the squire has any reaction ability like a/ma save, dragon spirit, etc. and it activates afterwards it'll always miss.

Also I tried using a dark element life drain on them and it had a wonky effect. If the attack succeeded (even though it always shows 0%) then the person that casted it got healed for the hp they would have gotten from the drain even though it would still miss on the squire. Basically it would work like normal except it didn't take any hp from the squire since it "missed".

Thanks again for trying to get this working, maybe it'll get there eventually.
Glain [Posts: 356] Logged
  • View Profile
  • share
  • [April 25, 2012, 03:03:30 AM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #63 on: April 25, 2012, 03:03:30 AM »
Good catch with the dark element life drain. Can't believe I didn't notice that earlier... (my test battle is Gate of Lionel... dark element life drain... now where have I seen that before? :<) I think I have a fix for that!

...As for nullified attacks having the reactions miss. I couldn't reproduce that, not exactly. The stat breaks are interesting though. I can't get MA Save to fire after a nullified stat break... ...even in vanilla. But in that case, it doesn't miss... it just doesn't fire at all whatsoever. I'm not really sure what's going on there, but I don't think this patch introduces that problem.

It's working for me with Sunken State though. I can't reproduce the problem. We're probably testing on two different platforms. Are you using an emulator? If so, do you have a savestate where it happens?

Anyway, here's the latest (should fix the drain problem)
Austin [Posts: 307] Logged
  • View Profile
  • share
  • [April 26, 2012, 02:09:56 AM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #64 on: April 26, 2012, 02:09:56 AM »
Alright, I just tried this one out and for whatever reason it looks like everything's working right. After using this patch I could only get certain abilities to go off like you too, brave up, caution, and dragon spirit I think all activated and worked like they were supposed to. I couldn't get regenerator to go off though despite it being one of the ones that did when I tried it before.

Either way if it's working there's no point worrying about it lol, it may have been something on my end that was messing it up. I am playing on the psxfin emulator if you still wanted to know though. Thanks for the help dude.  :P
ALL THE THINGS Official Caretaker.
RavenOfRazgriz (Global Moderator) [Posts: 2809] Logged
  • View Profile
  • share
  • [July 04, 2012, 10:55:49 PM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #65 on: July 04, 2012, 10:55:49 PM »
Anyone know how this hack interacts with other formula hacks?   Specifically ones that already have elemental routines?
4v4, Squire only, no swords, map 116
FFMaster [Posts: 2408] Logged
  • View Profile
  • share
  • [July 04, 2012, 11:14:41 PM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #66 on: July 04, 2012, 11:14:41 PM »
Will probably break them.

Multiple formula rewrites are bad unless you know exactly what is happening.

☢ CAUTION CAUTION ☢ CAUTION CAUTION ☢
Need a Dota 2 invite? PM me your Steam account and play with me, PX and others and we shall aim for the top!
Glain [Posts: 356] Logged
  • View Profile
  • share
  • [July 05, 2012, 03:54:01 PM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #67 on: July 05, 2012, 03:54:01 PM »
Well, the majority of what this hack does is just call the elemental routine after the formula code has already been called. It doesn't actually edit the formulas themselves except to null out (nop) any other calls to the elemental routine (0x186ff8) and its inner routine (0x184e98).

If a formula hack calls those routines explicitly, it would be a problem because the element would be applied twice. If formulas have been rewritten so that those calls aren't in the same place that they normally would be, that would be bad.

I don't think I've seen another hack that edits the end of the formula calling routine in the same way this one does, so I don't imagine there would be code overlap issues anywhere else.

It depends on what the other hacks do, I suppose, to really know whether they'd work in tandem, but it's probably worth a shot...
ALL THE THINGS Official Caretaker.
RavenOfRazgriz (Global Moderator) [Posts: 2809] Logged
  • View Profile
  • share
  • [July 05, 2012, 09:02:59 PM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #68 on: July 05, 2012, 09:02:59 PM »
So as long as those hacks don't edit the end of the formula calling routine and have their usually elemental callings nopped out, it should be fine?

I'm not really editing any existing formula, just adding new ones such as your MA*WP+Y and ride's White Wind and Damage=Y.  A couple are being actively edited but with that in mind I think things should be workable.

Thanks, Glain.
ALL THE THINGS Official Caretaker.
RavenOfRazgriz (Global Moderator) [Posts: 2809] Logged
  • View Profile
  • share
  • [July 23, 2012, 06:12:17 AM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #69 on: July 23, 2012, 06:12:17 AM »
Important question #2 regarding this hack: If I use this hack, then make a skill like Cure 2 Holy element, then have a character that Absorbs Holy, what will happen, Glain?  Will the healing be reversed into damage sortof like an Undead Reverse or will nothing happen?
Glain [Posts: 356] Logged
  • View Profile
  • share
  • [July 23, 2012, 06:42:05 PM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #70 on: July 23, 2012, 06:42:05 PM »
It looks like the absorb code for this hack is basically:

Healing = Damage
Damage = 0

If draining HP, then additionally:

Returned damage = returned healing
Returned healing = 0

The problem is that for heals, damage = 0, so with absorb, healing = 0.

Eyeballing the address, I think that's in kanji space, and I usually leave a bit of space between routines, so I think I can expand it to skip setting the healing = damage if the damage is 0.  You can try overwriting the F5DA0 segment in the patch with this and give it a go:


This modification was brought to you in accordance with Absolutely Zero Testing™.
« Last Edit: July 25, 2012, 01:42:37 AM by Glain »
Glain [Posts: 356] Logged
  • View Profile
  • share
  • [August 22, 2012, 03:36:59 AM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #71 on: August 22, 2012, 03:36:59 AM »
This version should work without having to remove (nop out) any other calls.  The idea was to place an immediate return statement at the start of the elemental and inner elemental routines, to make them do nothing, and shift the real routines one line down, making up the space somewhere in the process (removing a nop, reusing a register).


Patch and source are one and the same!  Formatting looks messed up here but should be right if you copy/paste into a file.
ALL THE THINGS Official Caretaker.
RavenOfRazgriz (Global Moderator) [Posts: 2809] Logged
  • View Profile
  • share
  • [August 22, 2012, 03:48:42 AM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #72 on: August 22, 2012, 03:48:42 AM »
Does this still fix Oil, fix rounding errors by modifying the final value and not the XA value, work with Healing and Absorb, etc?
Glain [Posts: 356] Logged
  • View Profile
  • share
  • [August 22, 2012, 05:08:50 AM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #73 on: August 22, 2012, 05:08:50 AM »
Yeah, I put the modification described in the last post in there, so healing should be preserved regardless of absorb.

And yep, all the other things should be in there too.
ALL THE THINGS Official Caretaker.
RavenOfRazgriz (Global Moderator) [Posts: 2809] Logged
  • View Profile
  • share
  • [August 22, 2012, 06:54:37 AM]
Re: ASM Request: Stat Down Skills Accept Element
« Reply #74 on: August 22, 2012, 06:54:37 AM »
Weeeee.  Sounds good.

Now do it again for the Status routine.  :U

But really, it's good to have a much more user-friendly version of this ASM.  How hard would customizing which elements are affected by Oil be?  I don't personally need it but I know it's a nice bit of customization a lot of people would appreciate.
Pages: 1 2 3 [4]