orgASM's skill above short charge

[y22bc]

Hi,
I have a problem regarding orgASM's "blank support ability over short charge adds 25% bonus skill hit"(skill id 01E1)
It only adds 1% bonus for some reason
I know its suppose to work because FFT:plus uses it
Following is what I did
  prepared a clean ISO
  used orgASM first
  also, applied change start menu to continue
  used FFTpatcher to set 01E1 to knight's RSM
  started a newgame
So, anyone can teach me what I'm doing wrong?

[Argy]

Hi,

I have just tried it as well, with a clean iso but I patched orgASM last and I got no increase whatsoever.
Has anybody else had any success with using the above skill? (apart from FFT:Plus)
Cheers Argy

[Choto]

-Don't load from a save-state, don't think that's a problem here though just stating
-The bonus hit only works for certain formulas

spoiler: Formula list

00189020: 0E Dmg_(Y)% Hit_F(MA+X)% 100% Status Hide Status
001892dc: 1A Hit_F(MA+Y)% // -PA/MA/SP_(X)
001898b8: 28 StealExp_(Lowest of TarCurExp & SP+Y) Hit_(SP+X)%
00189928: 29 OppositeSex: Hit_(MA+X)%
00189a4c: 2B Hit_(PA+X)% // -PA/MA/SP_(X)
00189dac: 32 Dmg_(Rdm(1...X)*(PA*3+Y))
00189e50: 33 Hit_(PA+X)%
00189f28: 35 Heal_(Y)% Hit_(PA+X)%
0018a044: 3F Hit_(SP+X)%
0018a0a0: 40 Undead: Hit_(SP+X)%
0018a510: 51 Hit_(MA+X)%
0018a84c: 58 Generic: Set_Morbol: Hit(MA+X)%

-the hack is called in a couple other places too though:

spoiler: Other Formulas?

001886e4: Routine used in formula 2B
00188818: MA + X
001888a0:
001889e4: Calculate Accuracy for Magical Spells
00188a44: Calculate Accuracy for Magical
00188aa4:
00188b2c: Physical Routine for Hit % abilities

So it might affect other things as well.

Anyways, make sure you use one of those formulas when you check for it. I'll take a look at the code

[Argy]

Hi Choto,

I tried it on formula 29, which is Steal Heart and I got no love from at it all. (Figuratively and Literally!!)
I haven't tried the others though.
Thanks for all of your hard work Choto.
Cheers Argy

[Choto]

Here try this hack:

spoiler: Accuracy hack

<Patch name="Support under Equip Change adds 20% Hit (with Xif's Hack)">
<Description>
     What's a description. 
    </Description>
<Location file="BATTLE_BIN" offset="11e9cc">
        FC470508
   00000000
       </Location>
       <Location file="BATTLE_BIN" offset="EAFF0">
1980043C
942D848C
00000000
92008490
10000334
06006414
00000000
   </Location>
   <Location file="BATTLE_BIN" offset="EB00c">
14004224
64004328
02006014
00000000
64000224
2A00A2A4
21800001
75160608
00000000
    </Location>
<Location file="BATTLE_BIN" offset="11f5d8">
1980013C
CE382294
CE3830A4
D03822A4
D0382394
CE382294
92006492
10008430
03000410
21104300
14004324
21106200
902D248C
       </Location>
  </Patch>

This is a hack that makes 0x1E1 bandit's eye from JoT5. It should work with more formulas than the original but I think it doesn't calculate totally accurately. There will be a little fluctuation in hit% but not enough to cause an alarm. I think it was only for like 70 total evade or so when it kicked in.

Thanks Argy, it's nice to know somebody's making use of the hacks :)

[Argy]

Choto!
I admire someone that can look at code and know what it does. I look at it, scratch my head and say thank god to people like you!
I will have a crack at this tomorrow.
Cheers Argy

[y22bc]

I think I found what was wrong, but I don't have time to test it right now

here's 01E1 patch that came with fftpatcher 482 v2

1980013C CE382294 942D248C CE3830A4 92008490 D03822A4 10008430 03000410 21100202 82181000 21106200 902D248C
00000000

and the next one is from dome's fftplus copied and pasted from
http://ffhacktics.com/smf/index.php?topic=7324.msg148174#msg148174

1980013C CE382294 CE3830A4 D03822A4 D0382394 CE382294
92006492 10008430 03000410 21104300 82180200 21106200
902D248C

I don't even know what these numbers represent, so I can be completely wrong to assume that I found the bug in patcher's hack

[Argy]

Thank you Choto,

I have tried the Bandit's eye from JoT5 and it most definitely works.  I tried it with Steal Heart and it was giving 100% charm on the Ghosts (3 different ones, with three diff compats). I will have a look at how it goes again human classes.
Can you also let me know what other routines it effects and I can have a look at them, when RL, doesn't get in the way!
Once again, thank you for your work.

Cheers Argy

[y22bc]

Just finished testing dome's 01E1 thing and got it right

[Choto]

sweet, nice work y22bc

@argy - I think the old hack only affected status-inflicting formulas only.. and I added a portion that affects damage abilities. I'm not even sure all the routines that are affected. It may be a case of it is what it's gonna be. Ask me again later though if you feel like looking into it.

[Argy]

Thanks Choto.

I will probably look into it at a later date, I am happy with what I have at the moment.

Cheers Argy