ASM hack not working as intended

[apollo326]

Hello this is my first post on these forums(I think?) but I have been lurking for awhile. Anyways onto the reason for this post.

I was applying the "Elemental Fix (v3) FIXES HOLY SWORD AND OIL" hack from FFTorgASM found here:

spoiler

<Patch name="Elemental Fix (v3) FIXES HOLY SWORD AND OIL">
    <Description>
      Strengthen is W / 128 * Damage
      Absorb is X / 128 * Damage
      Resist is Y / 128 * Damage
      Weak is Z / 128 * Damage
      NOTE: The above are to final damage.  This means the round-off errors are minimized compared to FFT.  A list of common percentages:
        190% is F4
        183% is EB
        180% is E7
        175% is E0
        170% is DA
        166% is D6
        160% is CD
        150% is C0
        140% is B4
        133% is AB
        130% is A7
        125% is A0
        120% is 9A
        117% is 96
        110% is 8D
        100% is 80       
        90% is 74
        83% is 6B
        80% is 67
        75% is 60
        70% is 5A
        66% is 56
        60% is 4D
        50% is 40
        40% is 34
        33% is 2B
        30% is 27
        25% is 20
        20% is 1A
        17% is 16
        10% is D
      If the ability has "Weapon Strike", the ability will stack both the elementals from the weapons and from the ability.  A consequence of this is that the first attack in FFTP must now be flagged as weapon strike or elemental weapons will not work.
      If you want to only use the ability elemental, unflag "Weapon Strike".
      If you want to only use the weapon elemental, flag "Weapon Strike" and set the ability as non-elemental.
      This hack also bundles the Float = Weak to Wind hack. If you don't want this feature, don't change 11FD48 or 11FD54.
    </Description>
    <Location file="BATTLE_BIN" offset="ec6dc">
      1980053C
      942DA58C
      90014194
      7100A590
      00000000
      24188500
      04006010
    </Location>
    <Variable file="BATTLE_BIN" offset="EC6F8" default="A0" name="W"/>     
    <Location file="BATTLE_BIN" offset="ec6F9">
      000334
      19006100
      12080000
      C2090100
      0800E003
      900141A4
    </Location>
    <Location file="BATTLE_BIN" offset="11de98">
      1980023C
      F3384390
      F7384490
      04394590
      04006330
      02006010
      E8FFBD27
      25208500
      982D428C
      1000BFAF
      B74D050C
      00000000
      6D004590
      9C014194
      24188500
      08006010
      00042334
      90014194
      9C0143A4
    </Location>
    <Variable file="BATTLE_BIN" offset="11DEE4" default="80" name="X"/>     
    <Location file="BATTLE_BIN" offset="11DEE5">     
      000334
      19006100
      12080000
      C2090100
      900141A4
      6E004590
      00000000
      24188500
      05006010
      00000000
      9013060C
      00000000
      E3130608
      00000000
      6F004590
      90014194
      24188500
      05006010
    </Location>
    <Variable file="BATTLE_BIN" offset="11DF2C" default="40" name="Y"/>     
    <Location file="BATTLE_BIN" offset="11DF2D">
      000334
      19006100
      12080000
      C2090100
      900141A4
      5A004190
      70004590
    </Location>
    <Location file="BATTLE_BIN" offset="11DF48">
      40002330
      02006010
    </Location>
    <Location file="BATTLE_BIN" offset="11DF50">
      80002330
    </Location>
    <Location file="BATTLE_BIN" offset="11DF54">
      1000A534
    </Location>
    <Location file="BATTLE_BIN" offset="11DF58">
      02006010
      90014194
      8000A534
      24188500
      08006010
    </Location>
    <Variable file="BATTLE_BIN" offset="11DF6C" default="FF" name="Z"/>     
    <Location file="BATTLE_BIN" offset="11DF6D">
      000334
      19006100
      12080000
      C2090100
      9C014394
      900141A4
      00086334
      9C0143A4
      1000BF8F
      1800BD27
      0800E003
      00000000
    </Location>
    <Location file="BATTLE_BIN" offset="11EFC2">42</Location>
    <Location file="BATTLE_BIN" offset="11F01A">42</Location>
  </Patch>

When I do so Oil works fine and spell damage works fine but elementally boosting physical attacks(like using a 108 gems+coral sword or earth slash) no longer works.

I tested on a clean ISO and on neutral compat characters.

Any ideas?

[Choto]

Probly just a bug with the code, somebody will have to look at it to figure out the bug.

when JoT5 chapter 2 is out I'll take a look back at this, but remind me if I forget >_>